search

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Client Command Broken Because of the RootChain Contract Changes #89

Closed maxweng closed 6 years ago

maxweng commented 6 years ago

Although all tests run through without problems for me, some of the client commands, like deposit and withdraw are broken in the command line. I guess it's because RootChain.sol is updated. I've fixed the deposit command, which I changed the line 38 in file plasma/client/client.py from: self.root_chain.deposit(rlp.encode(transaction, UnsignedTransaction), transact={'from': '0x' + transaction.newowner1.hex(), 'value': transaction.amount1}) to: self.root_chain.deposit(transact={'from': '0x' + transaction.newowner1.hex(), 'value': transaction.amount1})

I also tried to fix the withdraw command, but got revert error when running against the Ganache-cli. Anyone has a similar problem?

smartcontracts commented 6 years ago

We're currently building out a testing language + integration tests to fix this sort of problem. We definitely need to bring the child chain back up to speed with the latest root chain contract. Expect this to be less of an issue as we finalize the MVP contract.

smartcontracts commented 6 years ago

Thanks! Closing as fixed in #91