omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Fix depositing from CLI #91

Closed takashi closed 6 years ago

takashi commented 6 years ago

from this commit, the command deposit does not work with the error like TypeError: deposit() takes 2 positional arguments but 3 were given

this is because the arguments of deposit func on client/client.py has been changed on this commit

And also the deposit func on client/client.py does not work since the root chain function has been changed ref: https://github.com/omisego/plasma-mvp/issues/89#issue-312294240

smartcontracts commented 6 years ago

LGTM

DavidKnott commented 6 years ago

@takashi Thanks a lot! Merging.

takashi commented 6 years ago

thx for merging!