search

omgovich / colord

👑 A tiny yet powerful tool for high-performance color manipulations and conversions
https://colord.omgovich.ru
MIT License
1.67k stars 49 forks source link

feature: cmyk plugin implementation #58

Closed EricRovell closed 3 years ago

EricRovell commented 3 years ago

Implemented the CMYK plugin. It adds the functionality to convert the color to CMYK color model object, convert to CMYK color string and parsing the CMYK color objects. Updated the documentation . Implemented and ran the tests.

omgovich commented 3 years ago

Oh, wow! Amazing job! 🔥 Thanks a lot for that.

The code looks great but there is a few eslint warning that we need to fix before merge. Please run npm run lint in the project root to lint the code.

EricRovell commented 3 years ago

Got it!

codecov-commenter commented 3 years ago

Codecov Report

Merging #58 (e8a589c) into master (c0bdc02) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        37    +2     
  Lines          441       482   +41     
  Branches        96       108   +12     
=========================================
+ Hits           441       482   +41
Impacted Files Coverage Δ
src/colorModels/cmyk.ts 100.00% <100.00%> (ø)
src/plugins/cmyk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0bdc02...e8a589c. Read the comment docs.

EricRovell commented 3 years ago

You are welcome, I will be back with more :)