omgovich / react-colorful

🎨 A tiny (2,8 KB) color picker component for React and Preact apps
https://omgovich.github.io/react-colorful
MIT License
3.19k stars 100 forks source link

Update ARIA attributes on ranges #177

Closed aitchiss closed 2 years ago

aitchiss commented 2 years ago

Fixes https://github.com/omgovich/react-colorful/issues/171

In the Hue component:

In the Alpha component:

In the Saturation component:

No change has been made! I don't believe there is an available numeric representation of the current value, so in this case I believe we can omit aria-valuenow for the time being until https://github.com/omgovich/react-colorful/issues/152 is addressed.

Snapshot tests have been updated to reflect the new attributes 🙂

Check out the docs for aria-valuenow for more context

omgovich commented 2 years ago

Oh, wow! Thanks a lot for this contribution! I'll check it as far as I can!

omgovich commented 2 years ago

Tested it locally with VoiveOver and added a simple test for that. Everything works well. Thanks again!

aitchiss commented 2 years ago

Thank you @omgovich!

smellai commented 2 years ago

@aitchiss thanks for this improvement! @omgovich looks like the demo in the homepage is not updated yet with this change?

Looking forward the fix for #152 too