omid / Hijri-Calendar-for-Gnome-Shell

An extension for Gnome-Shell to show Hijri date/calendar
https://extensions.gnome.org/extension/1083/hijri-calendar/
GNU General Public License v3.0
24 stars 9 forks source link

Add English support #7

Open metinkale38 opened 6 years ago

metinkale38 commented 6 years ago

Hey,

i would find it usefull, if you could add english support. There could be a settings to show the digits and months in english.

I tried to do it, but somehow it didn't work, unfortunately i have not much experience in writing gnome extensions.

I really did not understand how it is working: you are using GetText, but i could not find any GetText files. If i edit a string to english, the string will not be shown in the UI.

omid commented 6 years ago

Hello,

It would be really nice if you can change it on your own and create a pull request.

The translation function is here: https://github.com/omid/Hijri-Calendar-for-Gnome-Shell/blob/master/strFunctions.js

I've used "format" function in the following files:

And you must add the translation option to the schema and the preferences:

I suggest you to add an option to the schema and the preferences files, then update format function to decide on it's own, to translate or not!

👍