search

omid / Persian-Calendar-for-Gnome-Shell

An extension for Gnome-Shell to show Persian date/calendar
https://extensions.gnome.org/extension/240/
GNU General Public License v3.0
394 stars 32 forks source link

Incorrect holidays #29

Closed papampi closed 4 years ago

papampi commented 5 years ago

First I should thank you for your awesome calendar,

Then, looks like holidays are outdated, For example, We have 2 holidays next week on 5th and 7th of Aban, but none marked in it.

omid commented 5 years ago

Thanks :-)

At least in this specific place, holidays are fine in the code

The problem is the Gregorian-to-Hijri converter which returns 29 days for Safar! So seems like it's time to change the library to something else!

omid commented 5 years ago

Most converters out there are based on http://www.staff.science.uu.nl/~gent0113/islam/ummalqura_converter.htm which shows Safar as 29-day month this year!

papampi commented 5 years ago

I know it must be such a headache to convert these dates while Iranian gov keeps changing them based on watching the moon for Eid-e-Fetr.

omid commented 4 years ago

Closed because it's duplicate of https://github.com/omid/Persian-Calendar-for-Gnome-Shell/issues/11