search

omid / Persian-Calendar-for-Gnome-Shell

An extension for Gnome-Shell to show Persian date/calendar
https://extensions.gnome.org/extension/240/
GNU General Public License v3.0
386 stars 31 forks source link

gnome 42 support added #96

Closed mhkarimi1383 closed 2 years ago

mhkarimi1383 commented 2 years ago

Solves https://github.com/omid/Persian-Calendar-for-Gnome-Shell/issues/95

I have tested things that I can But I have problem with some font sizes I thinks that's my problem Screenshot from 2022-02-20 22-46-31

omid commented 2 years ago

Thanks for the PR. The week day labels are bigger than usual 🤔 Also the white box is huge 🙈

mhkarimi1383 commented 2 years ago

I think that's my system problem. others should test it as well

omid commented 2 years ago

I see it in another way... when it happens to you, it will happen to others.

mhkarimi1383 commented 2 years ago

My laptop screen is too small, I think I hade such problem before But it could ve better if others test it too if anyone has gnome 42

freakingeek commented 2 years ago

image

mhkarimi1383 commented 2 years ago

image

Now that's working :)

omid commented 2 years ago

Apparently it's gnome 41, isn't it @sttatusx ?

freakingeek commented 2 years ago

Apparently it's gnome 41, isn't it @sttatusx ?

No, it's GNOME 42.beta on debian sid

omid commented 2 years ago

🙈 It's broken for me, too.

Screenshot from 2022-02-23 18-45-51

mhkarimi1383 commented 2 years ago

That's because of gnome 42 styling changes so I think that's because css code are not responsible 😶 I will try to make it better🤓

freakingeek commented 2 years ago

That's because of gnome 42 styling changes so I think that's because css code are not responsible 😶 I will try to make it better🤓

Thanks!

mhkarimi1383 commented 2 years ago

found it.... the problem is coming from changes in gnome 42 calendar and we are using calendar-day-heading so I will fix it

by removing it and creating an alternative class for that

mhkarimi1383 commented 2 years ago

it has this line inside gnome sources

height: 16px !important;
mhkarimi1383 commented 2 years ago

so what got from our friend's screenshot is that the problem is from vazir font style witch is different from others also in stylesheets file the comment is important

omid commented 2 years ago

@mhkarimi1383 perfect, nice catch 👏🏼

I would suggest solving it in another way. It's better not removing the original css class, but just overwriting them. Because users may have different themes! (dark or bright color or whatever!)

So my suggestion is to just change the css to this:

.pcalendar-weekday .pcalendar-day {
    font-size: 1.1em;
    height: auto;
}
mhkarimi1383 commented 2 years ago

Okay nice suggestion 😃 I will do it

mhkarimi1383 commented 2 years ago

for me these changes was ok

omid commented 2 years ago

@mhkarimi1383 thanks a lot 🙏🏼 @sttatusx could you also test them in the meanwhile?

Anyway, I'll merge it now.

freakingeek commented 2 years ago

@mhkarimi1383 thanks a lot 🙏🏼 @sttatusx could you also test them in the meanwhile?

Anyway, I'll merge it now.

Hi Omid ( @omid ), Honestly, I do not use this extension, but I will leave the screenshot for you anyway.

image