search

omimo / PyMO

A library for machine learning research on motion capture data
https://omid.al/projects/pymo/
MIT License
350 stars 71 forks source link

Capitalize End Site in BVH file #14

Open seanschneeweiss opened 3 years ago

seanschneeweiss commented 3 years ago

Thank you for this great project, it really helped us a lot for our project RoseMotion.

Matlab requires to use End Site in the BVH file, so that the BVH importer identifies the end of the skeleton.

Do you think this change could break the behavior of other tools?

omimo commented 3 years ago

I'm glad you found PyMO useful.

I'll have to run some tests to make sure the exported BVH files load properly in some major tools. I'll get back to you.

seanschneeweiss commented 3 years ago

Thank you very much for testing. Could also be a bug in MATLAB :) Will test soon if it still persists in the newest MATLAB version.

seanschneeweiss commented 2 years ago

End Site seems to be the official capitalization. See https://research.cs.wisc.edu/graphics/Courses/cs-838-1999/Jeff/BVH.html and especially https://research.cs.wisc.edu/graphics/Courses/cs-838-1999/Jeff/Example1.bvh.