search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
255 stars 114 forks source link

Symfony 5 compatibility? #113

Closed vaibhavpandeyvpz closed 4 years ago

vaibhavpandeyvpz commented 4 years ago

Is this package compatible with Symfony 5?

MaximePinot commented 4 years ago

Not yet. It will be compatible when these two PRs are merged (and composer.json updated): #110 and #109.

vaibhavpandeyvpz commented 4 years ago

OK. I am inline.

Sent from my iPhone

On 22-Dec-2019, at 14:08, Maxime Pinot notifications@github.com wrote:

 Not yet. It will be compatible when these two PRs are merged (and composer.json updated): #110 and #109.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

vaibhavpandeyvpz commented 4 years ago

@curry684 Since you bumped the dependencies I saw, would you mind tagging it.

curry684 commented 4 years ago

You do not want that until I fixed everything to work with the new dependencies.

vaibhavpandeyvpz commented 4 years ago

I cannot do my project further until its updated so please forgive my eagerness. Please take your time.

curry684 commented 4 years ago

Wise lesson for the next time - do not upgrade to a new Symfony major version until it's been out for at least 3 months so dependencies have caught up 😉

curry684 commented 4 years ago

You should be able to test dev-master right now. Keep me posted if you see anything unexpected.

vaibhavpandeyvpz commented 4 years ago

OK. Giving it a try.

curry684 commented 4 years ago

No weird stuffs? I'm getting 2 worrying errors out of the unit tests I can't really explain.

curry684 commented 4 years ago

Fixed those, still got a bunch of crashes in unit tests but non-functional.

https://github.com/omines/datatables-bundle/releases/tag/0.4.0

Submit issues (or preferably PRs) if you find anything.

vaibhavpandeyvpz commented 4 years ago

@curry684 Its working great with Symfony 5 and I came back to thank you and the contributors for creating such a great package that saves time while maintaining project structure. It's one of the most useful package ever to me.

curry684 commented 4 years ago

Thanks, highly appreciated 😄

Happy new year!

vaibhavpandeyvpz commented 4 years ago

HNY to everyone! 🎆