search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
255 stars 114 forks source link

Bugfix broken test #125

Closed vitormattos closed 4 years ago

vitormattos commented 4 years ago

The parent tearDown method make the unset client and run all necessary.

With this, the continuous integration works again and the tests pass again

curry684 commented 4 years ago

Heya, thanks for the fix, but why did you move the Symfony requirements up? Does not seem required in this context.

vitormattos commented 4 years ago

@curry684 after the bugfix the tests were breaking with the previous versions. I think you can follow the builds generated in each push I did.

curry684 commented 4 years ago

Fixed it separately, still compatible with 4.1 now. Thanks!