search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
255 stars 114 forks source link

Make methods and properties of ORMAdapter protected instead of private #134

Closed danut007ro closed 4 years ago

danut007ro commented 4 years ago

This is needed in order to be able to extend ORMAdapter without duplicating the building of its properties.

curry684 commented 4 years ago

Please read http://fabien.potencier.org/pragmatism-over-theory-protected-vs-private.html on why Symfony decided to consciously change most of its protected methods to private. We will not be opening up the internal API without need.

Can you elaborate on what you are trying to achieve?

danut007ro commented 4 years ago

Hi again,

I'm trying to extend getResults method in ORMAdapter (see https://github.com/omines/datatables-bundle/pull/128). Right now I have to duplicate the manager and hydrationMode properties in my class in order to keep the method doing the same thing.