WIP: Fix Scrutinizer and SymfonyInsight

omines / datatables-bundle

DataTables bundle for Symfony

https://omines.github.io/datatables-bundle/

MIT License

262 stars 114 forks source link

WIP: Fix Scrutinizer and SymfonyInsight #140

Closed freezy-sk closed 4 years ago

curry684 commented 4 years ago

Mmm I already did this I think? 😉

curry684 commented 4 years ago

https://github.com/omines/datatables-bundle/commit/8cb8ce0bc72667d940cc6082024d62cfb0a2063d

freezy-sk commented 4 years ago

@curry684 I know, but it's a hack. This bundle does not depends on ocramius/package-versions so it shouldn't be there just to solve problems of CI platforms.

curry684 commented 4 years ago

Agreed from a purist view but I didn't really bother because it's only needed in dev dependencies (and I also wasted an hour before, trying to fix it better to no avail).

curry684 commented 4 years ago

Scrutinizer is fixed and I remove Symfony Insights as it had no added value anyway anymore.

Still thanks for the effort 👍