search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
255 stars 114 forks source link

Use trans() for proper locale fallback when using CDN languages #141

Closed freezy-sk closed 4 years ago

freezy-sk commented 4 years ago

@jkabat mentioned in #136 that he uses fr_FR as locale. this update should fix this issue when cdn language is configured with supported locale, but used with defined region

curry684 commented 4 years ago

This makes sense I think, but doesn't this also require an update to https://github.com/omines/datatables-bundle/blob/master/bin/update-translations to avoid it removing the file properties next time it's run?

freezy-sk commented 4 years ago

@curry684 there's no need to update that script, because file property is in own file DataTablesCDN.{locale}.yml

curry684 commented 4 years ago

@shades684 whatcha think?

curry684 commented 4 years ago

@freezy-sk could you check why it breaks all tests? Master branch is passing right now (don't think it was when you started this).

freezy-sk commented 4 years ago

@curry684 I squashed and rebased but it's still failing on ocramius/package-versions

curry684 commented 4 years ago

Yep, started breaking again in master as well 😕

curry684 commented 4 years ago

👍