Add opcache preloading support

omines / datatables-bundle

DataTables bundle for Symfony

https://omines.github.io/datatables-bundle/

MIT License

262 stars 114 forks source link

Add opcache preloading support #197

Closed trandbert37 closed 3 years ago

trandbert37 commented 3 years ago

Fixing #196

curry684 commented 3 years ago

Out of curiosity: why does this fix the issue? Shouldn't opcache preloading support anonymous classes?

The fix seems fine but well, it was inline for a reason.

trandbert37 commented 3 years ago

It seems to be a php bug and was fixed in php 7.3.13

curry684 commented 3 years ago

Ok but 7.3.13 was released a year ago on Dec 18 2019 and and 7.3 as a whole will go EOL in 8 days. So I don't really see a reason to fix it in our codebase now?

trandbert37 commented 3 years ago

Sorry, I meant 7.4.13

pkly commented 3 years ago

Sorry, I meant 7.4.13

so it's a fix for a bug fixed already?

curry684 commented 3 years ago

Not merging a fix for a single minor PHP release which was already fixed in upstream.