search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
251 stars 113 forks source link

test: add GitHub Actions #250

Closed Chris53897 closed 1 year ago

Chris53897 commented 2 years ago

Provide basic tests in GitHub Actions.

This needs improvments. But iin the actual state it already can help developers to run there PR against tests.

Ahummeling commented 2 years ago

I would like to bring to your attention that the successful php8.0 and php8.1 tests seem to be false positives. https://github.com/Chris53897/datatables-bundle/runs/4731077536?check_suite_focus=true The tests are never executed, because simple-phpunit tries to install a phpunit version that is compatible with the phpunit-bridge (v4.4.9) and the php version (8.0.13), however, no such version exists (that would be 9.5 or something, but 8.3 is the latest version supported by the symfony bridge).

Chris53897 commented 2 years ago

You are right . The --prefer-lowest tag should be only added for the lowest supported php version.

maxhelias commented 2 years ago

The "symfony/phpunit-bridge" does not need to have different version support, i think just remove the "^4.4" support for this package should be fix this

Ahummeling commented 2 years ago

Actually, considering this from phpunit_bridge documentation

The PHPUnit bridge is designed to work with all maintained versions of Symfony components, even across different major versions of them. You should always use its very latest stable major version to get the most accurate deprecation report.

Perhaps it is wise to even pin it to ^6.0, what do you guys think?

maxhelias commented 2 years ago

Perhaps it is wise to even pin it to ^6.0, what do you guys think?

I agree with that 👍

Chris53897 commented 2 years ago

This is just a basic workflow i copied and adjusted it a bit. quick and dirty to help with the symfony6 support. Maybe i should close the PR after that happened. Or if i find the time, i will improve it.

curry684 commented 1 year ago

Migration to Github Actions is done, however it does still need to be expanded to run for example the --prefer-lowest tests and allow failures in 8.2.

I'll keep this open as a WIP.

github-actions[bot] commented 1 year ago

Stale pull request message