omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
251 stars 113 forks source link

Update phpoffice/phpspreadsheet to v2 #330

Closed karstennilsen closed 4 months ago

karstennilsen commented 4 months ago

Improvement / replacement of https://github.com/omines/datatables-bundle/pull/329

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.45%. Comparing base (2c41aae) to head (989c450).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #330 +/- ## ======================================= Coverage 94.45% 94.45% ======================================= Files 36 36 Lines 956 956 ======================================= Hits 903 903 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

curry684 commented 4 months ago

Looks legit 👍

Keep in mind that this is technically a BC break and so will not be autoupdated without manually changing your dependency.

curry684 commented 4 months ago

Turns out your change doesn't break on v1 so we can support both.