omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
260 stars 114 forks source link

Add Excel OpenSpout exporter #332

Closed mhvis closed 6 months ago

mhvis commented 6 months ago

PhpSpreadsheet is not very performant for larger files. Here is a suggestion to add OpenSpout as an additional exporter. It performs ~40x faster in my test setup.

HTML tags are stripped from the input data because there is no rich text support in OpenSpout.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.45%. Comparing base (668e7bd) to head (4754054).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #332 +/- ## ======================================= Coverage 94.45% 94.45% ======================================= Files 36 36 Lines 956 956 ======================================= Hits 903 903 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

curry684 commented 6 months ago

Looks good, thanks 👍

curry684 commented 6 months ago

Published as well now, sorry.

mhvis commented 6 months ago

Thanks very much!