search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
251 stars 113 forks source link

Any concerns with Datatables 2? #345

Open craigh opened 1 month ago

craigh commented 1 month ago

Since Datatables is now at v2 (15 March 2024) Are there any compatibility issues you are aware of?

curry684 commented 1 month ago

I wasn't aware of this until I saw this issue, so no 😆 Too bad they still haven't got rid of jQuery like the rest of the world, but at least there's a vanilla API so you're no longer forced to use it.

Reading the upgrade guide I don't see anything that I expect to break. Technically we barely integrate with the library, it would seem the server-loading API's are (logically) unchanged, so I'm pretty confident you should be able to use it without (much) effort.

Ymmv, by all means try it out and let us know. I expect little to no issues but if you do notice strange stuff post it here, I'll keep the issue open for the time being.

Chris53897 commented 3 weeks ago

It works finde with Datatables V2. A small improve to this lib would be to add the layout attribute in DEFAULT_OPTIONS

craigh commented 3 weeks ago

We have a pretty heavily customized version of this bundle in use (custom templates, custom columns, etc) and therefore we are having trouble with the upgrade because datatables.js v2 changes many of the css classnames and Dom identifiers. So it hasn't been smooth and I haven't finished making the needed changes.

Chris53897 commented 3 weeks ago

But this changes are related to Database V2 only, and not to this repo. Or does this repo needs more changes?