search

omines / datatables-bundle

DataTables bundle for Symfony
https://omines.github.io/datatables-bundle/
MIT License
258 stars 115 forks source link

ArrayAdapter renders value twice #70

Closed thijswiersema closed 5 years ago

thijswiersema commented 5 years ago

I was just trying out the bundle, seems promising. But I encountered a little bug on my first test setup.

The column ArrayAdapter is transforming and rendering the value twice. It appears to happen in the processRow function here https://github.com/omines/datatables-bundle/blob/37aaf560baabc8c621bfb6ae308eaa8933a85da1/src/Adapter/ArrayAdapter.php#L91

Seems to me the call on L101 is unnecessary.

shades684 commented 5 years ago

You're right, but as stated in issue #7 the ArrayAdapter is far from completed.

ceininger commented 5 years ago

Hello @curry684 is it possible to have a new release with this fix inclued. I'm facing a problem with DateTimeColumn and nullValue fallback getting transformed twice (and then fail because the 2nd time, $value is a string).

Thanks

curry684 commented 5 years ago

Fair enough https://github.com/omines/datatables-bundle/releases/tag/0.3.0

ceininger commented 5 years ago

Thanks a lot :)