omines / directadmin

PHP client library to manage DirectAdmin control panel servers.
MIT License
105 stars 47 forks source link

Implement "login keys" feature. #12

Closed titanomachy closed 8 years ago

titanomachy commented 8 years ago

The "Login keys" feature is not implemented.

DirectAdmin has a "login key" feature to get access to a user's account, but restrict access to some specified functionality. The feature is described here.

curry684 commented 8 years ago

I've done some practical testing with this over the weekend, and I'm curious: what does the library need to change even? Afaics it works fine to log in as a user with a login key, and all functions (if permitted) are available.

barryvdh commented 8 years ago

He probably wants the functionality to create/modify login keys using the API (CMD_API_LOGIN_KEYS)

curry684 commented 8 years ago

We had a mail discussion before this issue was posted, and it was about authentication :) Just don't think he realized it was functionally identical to a regular user login. Didn't test it though.

titanomachy commented 8 years ago

Yes he is correct. I read the documentation, but could not find anything about the login keys. Did not think of DA not making a distinction between the two. I'll test it this weekend.

curry684 commented 8 years ago

Alright, reopen it if it doesn't :)

titanomachy commented 8 years ago

Works fine. Some feedback about which CMDAPI* to enable when calling a method would be nice. Maybe the documentation is the best place for that. Source code shows it too of course. Probably should not be high on the list of features.

curry684 commented 8 years ago

The DA API is pretty much broken on that end. Even I spent like an hour getting a login key to actually work with limited access hehe.