search

omines / directadmin

PHP client library to manage DirectAdmin control panel servers.
MIT License
105 stars 47 forks source link

Keep lowest but allow failure #23

Closed barryvdh closed 7 years ago

barryvdh commented 7 years ago

Hope this is correct, so wait for it to pass ;)

barryvdh commented 7 years ago

Oh you disabled building Pull Requests on Travis?

Build type disabled via repository settings (pull_request).

curry684 commented 7 years ago

The tests are run on a live server as I have no mock or demo API server available, so yes I blocked the DDoS attack vector of PRs ;)

I disabled the prefer-lowest build because it was failing for weird reasons, so setting it to allow fails isn't really a solution, but I didn't have time to debug it. The failed tests at https://travis-ci.org/omines/directadmin/jobs/199407302 appear to be completely random so it requires some deep inspection.

barryvdh commented 7 years ago

Ok but when you allow it, at least you keep seeing it on your build matrix and know it when it's fixed. Now its just invisible.

I would take a wild guess at Guzzle ^6.0.1 fixing it; https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md#601---2015-05-27 with this commit https://github.com/guzzle/guzzle/commit/6f3db1618ef286e993db255b7a734f5cadb1f1a8 (Based on the failing commits being GET requests with the query being an array with multiple items)

curry684 commented 7 years ago

Looks worth a try, I'll just raise it to 6.1 as that contains other potentially relevant fixes.

barryvdh commented 7 years ago

Yeah fixed, so now you don't have to allow it to fail anymore ;)

curry684 commented 7 years ago

https://github.com/omines/directadmin/commit/f7d433474a036e32c6e4da49584c43618cae2cf6 :)