read_blif arguments incorrect

[GoogleCodeExporter]

What steps will reproduce the problem?
1. make clean && make
2.
3.

What is the expected output? What do you see instead?
SRC/odin_ii.c:332: error: too many arguments to function read_blif
SRC/odin_ii.c:332: error: void value not ignored as it ought to be

What version of the product are you using? On what operating system?
Downloaded source usin: svn checkout http://odin-ii.googlecode.com/svn/trunk/ 
odin-ii-read-only today (9/27/2011)
Running on Ubuntu.

Please provide any additional information below.
in file odin_ii.c, read_blif is called:
   blif_netlist = read_blif (global_args.activation_blif_file, lut_size);

in file read_blif.c, the function is defined as:
   void read_blif(char * blif_file)

Original issue reported on code.google.com by tpanof...@gmail.com on 27 Sep 2011 at 11:33

[GoogleCodeExporter]

This issue was closed by revision r114.

Original comment by andy16...@gmail.com on 6 Oct 2011 at 8:15

• Changed state: Fixed

[GoogleCodeExporter]

Removed additional parameter. Does that solve the problem for you? 

Original comment by andy16...@gmail.com on 6 Oct 2011 at 8:19

[GoogleCodeExporter]

Thanks, but no it did not. I re-downloaded the complete source. The command I 
issued to do the download is:
svn checkout http://odin-ii.googlecode.com/svn/trunk/ odin-ii-read-only

I am targeting VPR5. I did a successful make in libvpr_5. I edited the ODIN_II 
Makefile line 3 to read 'BUILD = VPR5'. When I make there, I get an error:

SRC/odin_ii.c: In function do_activation_estimation:
SRC/odin_ii.c:332: error: too many arguments to function read_blif
SRC/odin_ii.c:332: error: void value not ignored as it ought to be

It looks to me that the read_blif.c file I got in the download is not the same 
version as the rest of the source.

Original comment by tpanof...@gmail.com on 6 Oct 2011 at 8:45

[GoogleCodeExporter]

Ok, I downloaded the complete source again, but this time without the 
odin-ii-read-only label. I performed the same steps as outlined in my previous 
comment. Indeed, your edit changed the errors to eliminate the too many 
arguments, but the other error is still there:
SRC/odin_ii.c: In function do_activation_estimation:
SRC/odin_ii.c:332: error: void value not ignored as it ought to be

This is not so easy to fix as odin_ii.c needs the netlist returned by read_blif.

[sorry for the noobishness, I am just a hardware hacker trying to experiment 
with FPGA tools]

Original comment by tpanof...@gmail.com on 6 Oct 2011 at 11:30

[GoogleCodeExporter]

Thanks for your reply. 

The problem is that you're using the VPR5 flag when compiling and 
do_activation_estimation was written using a much older version of read_blif.c. 
So some additional work needs to be done to make that code work with the 
current version of read_blif. For now you can comment out this function if you 
want to use VPR5. Otherwise, you could change your Makefile to use VPR6 which 
is the version we're currently working with. 

Original comment by andy16...@gmail.com on 7 Oct 2011 at 1:04

• Changed state: WontFix

[GoogleCodeExporter]

Aha, now I understand that current work has broken the VPR5 stream. 
Unfortunately, I have a rather large investment of effort in using VPR5 and it 
would be expensive for me to convert to VPR6. Can you identify a label or 
revision where the VPR5 version still works?

Original comment by tpanof...@gmail.com on 7 Oct 2011 at 3:29

[GoogleCodeExporter]

Give me a minute...I'll see if I can comment out that function and get it to 
compile for you. 

Original comment by andy16...@gmail.com on 7 Oct 2011 at 4:23

[GoogleCodeExporter]

Give the latest version a try. Activation estimation still needs some 
attention, but the compiler seems to be working OK with VPR5 now. 

Original comment by andy16...@gmail.com on 7 Oct 2011 at 4:37

• Changed state: Fixed

[GoogleCodeExporter]

It now works for me with the VPR5 flag "out of the box". Thank you for your 
help.

Original comment by tpanof...@gmail.com on 7 Oct 2011 at 4:49