Closed guzzilar closed 9 years ago
Oops, wait it failed in CircleCI
Ok, fine. let's continue review :smile:
Great!
FYI: for the committed 0372d27
At the begin, I created a new file source/javascripts/card-2.0.0.js.coffee
for dev card.js version 2 and leave the old one in source/javascripts/card.js.erb
.
So, when the committed 0372d27
comes, I decided to remove source/javascripts/card-2.0.0.js.coffee
and moved code into source/javascripts/card.js.erb
. Also, changed the file extension from card.js.erb
to card.js.coffee
.
So, when you look in the Git file changed. It will show as
source/javascripts/card-2.0.0.js.coffee
to source/javascripts/card.js.coffee
source/javascripts/card.js.erb
PR Purpose
The effect after you merge this PR.
It will be possible to move all of card.js files inside
card.omise.co
tocdn.omise.co/...
The deployment instruction
The steps to deploy are as follows:
/build/javascripts/card.js
tohttps://cdn.omise.co/
/build
folder tohttps://cdn.omise.co/card-2.0
(you could remove
https://cdn.omise.co/card-2.0/javascripts/card.js
because we will keep it outside of this folder (see above)).Noted:
https://cdn.omise.co/card-2.0
) you could change it insource/javascripts/card-2.0.0.js.coffee
Line 10:
@directory = "/card-2.0"