omise / card.js

Deprecation Notice: Moved to Omise.js
6 stars 3 forks source link

Correct links in document, prepare code for a new structure of the card.js's iframe #9

Closed guzzilar closed 9 years ago

guzzilar commented 9 years ago

PR Purpose

It will be possible to move all of card.js files inside card.omise.co to cdn.omise.co/...

The deployment instruction

The steps to deploy are as follows:

Noted:

guzzilar commented 9 years ago

Oops, wait it failed in CircleCI

guzzilar commented 9 years ago

Ok, fine. let's continue review :smile:

fred commented 9 years ago

Great!

guzzilar commented 9 years ago

FYI: for the committed 0372d27 At the begin, I created a new file source/javascripts/card-2.0.0.js.coffee for dev card.js version 2 and leave the old one in source/javascripts/card.js.erb.

So, when the committed 0372d27 comes, I decided to remove source/javascripts/card-2.0.0.js.coffee and moved code into source/javascripts/card.js.erb. Also, changed the file extension from card.js.erb to card.js.coffee.

So, when you look in the Git file changed. It will show as