search

omise / omise-android

Omise Android SDK
https://docs.opn.ooo
Other
50 stars 32 forks source link

Add acs check #320

Closed AnasNaouchi closed 7 months ago

AnasNaouchi commented 7 months ago

Description

Add a condition to check if the auth url requires 3DS processing. If not open web view.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mmkittisak commented 7 months ago

Can we add unit test for that function?

AnasNaouchi commented 7 months ago

Can we add unit test for that function?

The thing is that this function is in a class that is covered by android instrumentation tests. These tests were so flaky so we disabled them and we have a task to fix. We will add once we fix the issue.