omise / omise-ios

Omise iOS SDK
https://www.opn.ooo
MIT License
74 stars 36 forks source link

Installation hangs via Carthage #58

Closed jonathanlu813 closed 6 years ago

jonathanlu813 commented 6 years ago

Hi,

I was trying to integrate Omise iOS SDK into my project via Carthage, which is the only supported package manager by now, but failed. Here are some details:

After adding omise-ios to my Cartfile and run carthage update, the update process hangs after the line

*** Checking out omise-ios at "v2.6.0"

If I remove omise-ios and run again, it will go through to the build phase.

I've worked around this issue by requesting Omise Token API by myself, so it's not urgent for me, but I think I should report this to you guys anyways.

pitiphong-p commented 6 years ago

Hi @jonathanlu813, thank you for reporting this bug. I have done some investigation and found something that may be the cause.

Since Omise for iOS SDK includes the Card.io feature which need to be built and bundled alongside with the Omise for iOS SDK, we added it as a git submodule dependency. This can cause the Carthage to fetch the Card.io repo which is a big git repository and could take a long time to fetch it. You can check if git is fetching the Card.io repo by running ps command which will show what git is doing.

Could you try again and please give it some more time to checkout this time.

jonathanlu813 commented 6 years ago

Hi @pitiphong-p, I just checked with ps | grep git and found it was indeed cloning Card.io. I'll leave it there and go to bed now, and see if it can build successfully tomorrow morning. I'll keep you updated.

jonathanlu813 commented 6 years ago

Confirmed it's related to cloning Card.io. Installation succeeded after I left it updating overnight.

pitiphong-p commented 6 years ago

Great!!! Thank you for reporting this and I would love to hear some feedback from you if you have.