Closed aashishgurung closed 2 years ago
Prevent merchants from entering invalid Omise Payment keys.
Jira Ticket: #1465 (https://omise.atlassian.net/browse/FRON-1465)
Created a new plugin or interceptor ConfigSectionPaymentPlugin which holds logic to check the validity of the keys before saving it to the database. Did some refactoring on the Omise\Payment\Model\Config\Config.php.
ConfigSectionPaymentPlugin
Omise\Payment\Model\Config\Config.php
Run these command before testing:
php bin/magento cache:flush php bin/magento setup:di:compile
Go the the payment configuration section and test the following cases.
Should be a success:
Should fail
🔧 Environments:
sorry I just saw PR is still in draft mode, can ignore my comments for now 🤦🏽
1. Objective
Prevent merchants from entering invalid Omise Payment keys.
Jira Ticket: #1465 (https://omise.atlassian.net/browse/FRON-1465)
2. Description of change
Created a new plugin or interceptor
ConfigSectionPaymentPlugin
which holds logic to check the validity of the keys before saving it to the database. Did some refactoring on theOmise\Payment\Model\Config\Config.php
.3. Quality assurance
Run these command before testing:
Go the the payment configuration section and test the following cases.
Should be a success:
Should fail
🔧 Environments: