omise / omise-magento

Omise Magento Plugin
https://docs.opn.ooo/magento-plugin
MIT License
34 stars 19 forks source link

[APM2-795] missing translation #356

Closed new4762 closed 2 years ago

new4762 commented 2 years ago

1. Objective

After changing language to Thai, some text is still in English

Fixing missing translation and add payment method is not currently available messages after this PR https://github.com/omise/omise-magento/pull/337

Related information: Related issue(s): https://opn-ooo.atlassian.net/browse/APM2-671

2. Description of change

🔧 Environments:

Platform version: Magento CE 2.2.3
Omise plugin version: Omise-Magento 2.26.0
Omise plugin version: Omise-php v2.13
PHP version: 7.1

✏️ Details:

pull this PR and run this following command to update translation

bin/magento setup:upgrade;
bin/magento setup:di:compile;
bin/magento setup:static-content:deploy th_TH -f
bin/magento cache:flush;

4. Impact of the change

image image image image

5. Priority of change

Normal

6. Additional Notes

Any further information that you would like to add.

som-m commented 2 years ago

Can we also add the translation for True Money Phone Number? Just saw that it is missing too. 🙏🏻

image
new4762 commented 2 years ago

Can we also add the translation for True Money Phone Number? Just saw that it is missing too. 🙏🏻 image

Sure krub . what message should is be na krub is it หมายเลขโทรศัพท์สำหรับ ทรูมันนี่ or something else 🙏

tanawin-opn commented 2 years ago

This message too krub "ใช้บัตรใหม่"

image
new4762 commented 2 years ago

@som-m @tanawin-opn here update for more missing translation krub -> https://github.com/omise/omise-magento/pull/356/commits/380b7b44e87efa3d537d9b1e51f334baa45ccd79 🙏

image