search

omise / omise-magento

Omise Magento Plugin
https://docs.opn.ooo/magento-plugin
MIT License
34 stars 19 forks source link

Issue#369: setup:di:complie issue on Omise\Payment\Block\Adminhtml\Sy… #370

Closed tuyennn closed 1 year ago

tuyennn commented 2 years ago

…stem\Config\Form\Field\Webhook

1. Objective

Error setup:di:complie issue on Omise\Payment\Block\Adminhtml\System\Config\Form\Field\Webhook

Related information: Related issue(s): #369

2. Description of change

Incorrect dependency in class Omise\Payment\Block\Adminhtml\System\Config\Form\Field\Webhook in vendor/omise/omise-magento/Block/Adminhtml/System/Config/Form/Field/Webhook.php \Magento\Store\Model\StoreManagerInterface already exists in context object

3. Quality assurance

🔧 Environments:

✏️ Details:

Run deployment on production or specific php bin/magento setup:di:complie

4. Impact of the change

No impact the context of Block already defined the StoreManagerInterface

5. Priority of change

Immediate

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aashishgurung commented 1 year ago

We’re going to close this since we are unable to replicate the issue. If this issue is still relevant, please feel free to reopen it with more details on how to replicate it and we’ll take another look.