omise / omise-magento

Omise Magento Plugin
https://docs.opn.ooo/magento-plugin
MIT License
34 stars 19 forks source link

[ENGA3-520]: Fixed the issue of FPX redirecting to cart page with invalid order status. Also added a delay in redirect process before fetching charge status. #389

Closed aashishgurung closed 2 years ago

aashishgurung commented 2 years ago

1. Objective

Fixed the issue of FPX redirecting to cart page with invalid order status. Also added a delay in redirect process before fetching charge status.

Jira Ticket: #520

2. Description of change

Currently our plugin checks for processing and pending order state only. This caused issue when the webhook updated the order state to failed before customer reaching the redirect URL. So, we added a check for failed order state as well for Offsite.

Plus, we added a delay of 0.5 secs in Offsite and Threedsecure redirect flow before fetching the charge. This delay will be removed once the payment flow is changed in the backend.

3. Quality assurance

Configuration settings

Test

🔧 Environments:

Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication