search

omise / omise-magento

Omise Magento Plugin
https://docs.opn.ooo/magento-plugin
MIT License
34 stars 19 forks source link

Add phone number field for Atome #425

Closed ajzkk closed 1 year ago

ajzkk commented 1 year ago

1. Objective

Add phone number field for Atome

2. Description of change

Screenshot 2023-04-12 at 2 17 17 PM
aashishgurung commented 1 year ago

Can we please add validations? Currently, it accepts string in the phone number field. It should accept +{countryCode}{phoneNumber}. Let's update placeholder as well.

ajzkk commented 1 year ago

Can we please add validations? Currently, it accepts string in the phone number field. It should accept +{countryCode}{phoneNumber}. Let's update placeholder as well.

Added validation for phone number. But let's not update placeholder for consistency between truemoney and atome.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

21.9% 21.9% Coverage
0.0% 0.0% Duplication