omise / omise-node

Omise Node.js Library
https://docs.opn.ooo
101 stars 52 forks source link

agent-base monkey patch breaks HTTPS requests #120

Open PicturElements opened 4 years ago

PicturElements commented 4 years ago

Up until version 6.0.0, the agent-base package was patching https.request. As a result, it could completely break requests made with the (url, options, callback) signature, as specified by the core https package. As this patch affects HTTPS requests made globally, unrelated code can be severely affected.

Fix: update to the latest version of https-proxy-agent (5.0.0) to fix this issue.