omise / omise-node

Omise Node.js Library
https://docs.opn.ooo
102 stars 53 forks source link

Update account #129

Closed bigomise closed 4 years ago

bigomise commented 4 years ago

1. Objective

Add support of account API

2. Description of change

3. Quality assurance

update account using the following code example:

const omise = require('omise')({
    publicKey: 'pkey_test_XXXXXX',
    secretKey: 'skey_test_XXXXXX',
    omiseVersion: '2019-05-29'
  });
 omise.account.updateAccount({ webhook_uri: 'https://my/web/hooks' }, function(err, account) {
    console.log(account);
  });

check if account are updated.

or use auto-tests - run npm test

4. Impact of the change

N/A

5. Priority of change

Normal

6. Additional Notes

N/A

rezigned commented 4 years ago

@bigomise I think we should separate code formatting to another PR. It obscures the actual changes.

bigomise commented 4 years ago

@bigomise I think we should separate code formatting to another PR. It obscures the actual changes.

@rezigned i've tried to run npm run jscs that is suggested by our document but it seems it needs a configuration for jscs.

i would like to keep the original format but it was changed by my vscode 😂 . Could you suggest me on this krub?

rezigned commented 4 years ago

@bigomise Ok krub 😆 . Let's merge :)

bigomise commented 4 years ago

thanks a lot krub @rezigned however, i don't have permission to merge it krub 😂. if you have a permission to do, please do for me na krub 🙇 thank you again krubbbbb.