search

omise / omise-node

Omise Node.js Library
https://docs.opn.ooo
101 stars 52 forks source link

Remove use of dependency expressions for better bundling #166

Closed cpvdeveloper closed 1 year ago

cpvdeveloper commented 1 year ago

Fixes https://github.com/omise/omise-node/issues/140 Copy of https://github.com/omise/omise-node/pull/141

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

danfowler commented 1 year ago

@cpvdeveloper can you resolve conflicts?

Uponn commented 1 year ago

I've tested this locally and it still solves the issue, could this be merged since this is a blocker of mine, please :)

danfowler commented 1 year ago

@Uponn Thanks. What I mean is: can you resolve the conflicts in your branch?

steliyannedev commented 1 year ago

@danfowler I'm not the owner of this PR I just tested the fix locally but if needed I could push the fix.

aashishgurung commented 1 year ago

Fixed by #190.