Closed guzzilar closed 7 years ago
Does it need to be 'SSL' literally? The code seems to expect 3rd argument to be boolean so it could be 'true' instead.
The following code has the same effect:
$this->url->link('some/url', '', 'SSL'));
$this->url->link('some/url', '', 'noSSL'));
Never mind, I looked into the source code and found that they are using 'SSL' literally.
@nimid The plugin is very buggy without this PR. Especially, when using AJAX with HTTPS.
@iwat Ok.
1. Objective reason
To support OpenCart SSL configuration. If we look at the core code:
so, we could just add a param at the 3rd arg of that
Url::link()
method to tell OpenCart that we will use "SSL" config if it's possible (config_secure
=true
).i.e.
$this->url->link('some/url', '', 'SSL'));
2. Description of change
src/catalog/controller/payment/omise.php
to supportSSL
config3. Users affected by the change
None
4. Impact of the change
None, it still support for
http
as normal.5. Priority of change
Normal.
6. Alternate solution (if any)
No.