omise / omise-prestashop

Omise PrestaShop Plugin
https://docs.opn.ooo/prestashop-plugin
MIT License
4 stars 7 forks source link

Display the checkout form at the front-end #11

Closed nimid closed 7 years ago

nimid commented 7 years ago

1. Objective

Display the checkout form at the front-end.

Related information: Related issue: - Related ticket: 1257 Required pull request: #10

2. Description of change

3. Quality assurance

Environments:

Details:

The screenshot below shows the checkout form at the front-end.

screenshot-localhost 1616 2016-12-20 17-45-13

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

-

guzzilar commented 7 years ago

FYI, @nimid

Im going to rebase #10 to this branch/PR. (since most of code has been reviewed/fixed, just few comments left but should be fine to rebase again once everything done in PR #10 )

guzzilar commented 7 years ago

note, to test this PR, it required to install module first (as mentioned in "Make sure that the Omise-PrestaShop has been installed and enabled."). But if you already installed and just replace the files, it will not work. (have to uninstall and install again).

screen shot 2560-01-12 at 1 39 41 pm

cc @nimid

guzzilar commented 7 years ago

@nimid just 6 comments here:

And done for the rest ✌️

guzzilar commented 7 years ago

fyi, rebased develop => #11 feature/display-checkout-form

nimid commented 7 years ago

@guzzilar For, https://github.com/omise/omise-prestashop/pull/11#issuecomment-272089413, I have noted. Thanks.

And I found it too. My case I need to delete and re-copy the module.

guzzilar commented 7 years ago

👍