Bundle Omise-PHP to the project - Githubissues

omise / omise-prestashop

Omise PrestaShop Plugin

https://docs.opn.ooo/prestashop-plugin

MIT License

4 stars 7 forks source link

Bundle Omise-PHP to the project #13

Closed nimid closed 7 years ago

nimid commented 7 years ago

1. Objective

Bundle a library, Omise-PHP, to the project. Omise-PHP will be used to interface with Omise API.

Related information: Related issue: - Related ticket: - Required pull request: #12

2. Description of change

Add Omise-PHP to the project in the directory, libraries\omise-php
A directory and files of Omise-PHP in the list below are not added to the project. 1 tests\ 2 .gitignore 3 circle.yml 4 composer.json 5 phpunit.xml

3. Quality assurance

Environments:

Platform: PrestaShop 1.6.1.6
Omise plugin: Omise-PrestaShop 1.6.0.0
PHP: 5.6.28
Omise-PHP: 2.6.0

Details:

This pull request does not required testing.

4. Impact of the change

-

5. Priority of change

Normal

6. Additional Notes

-

guzzilar commented 7 years ago

@nimid can you upgrade omise-php library to the latest one? (2.6.0)

Thanks & ok for the rest 👍

guzzilar commented 7 years ago

@nimid fyi, going to rebase #12

guzzilar commented 7 years ago

rebased #12 feature/create-card-token => feature/bundle-omise-php

guzzilar commented 7 years ago

fyi, rebased with #12

guzzilar commented 7 years ago

fyi, rebased with develop

nimid commented 7 years ago

@guzzilar https://github.com/omise/omise-prestashop/pull/13#issuecomment-271860607

Done. 99b05488adae98849db7e919ad6da50de32d78a3

guzzilar commented 7 years ago

👍