Refactor the process of create Omise charge by extract class

[nimid]

1. Objective

Reduce the dependencies and functionality of a controller class, OmisePaymentModuleFrontController, by using a refactoring technique, extract class.

The OmisePaymentModuleFrontController has been used to create Omise charge.

According to the pull request #17, it has emphasized the class, OmisePaymentModuleFrontController, has many dependencies and functionality. This situation may tend to the class has error prone, especially in part of software maintenance.

Including the next steps, this class will been modified to add more functions such as store the order, handle the errors and display the proper result.

So, it will be better to reduce the dependencies and functionality of a class, OmisePaymentModuleFrontController.

Related information: Related issue: - Related ticket: - Required pull request: #17

2. Description of change

• Add a new delegate class, Charge, to create Omise charge request and interface with Omise-PHP.
• Remove all functions in controller class, OmisePaymentModuleFrontController, that have been moved to delegate class.

3. Quality assurance

Environments:

• Platform: PrestaShop 1.6.1.6
• Omise plugin: Omise-PrestaShop 1.6.0.0
• PHP: 5.6.28
• Mozilla Firefox: 50.1.0

Details:

• Make sure that the Omise-PrestaShop has been installed and enabled.
• At the front-end, add a product to cart.
• Proceed to checkout.

Test case 1: Successfully checkout

• At the step, 05. Payment, fill the valid card information and click button, Submit Payment. The system will process the payment and display the result page.

The screenshot below shows the result page display the successful payment.

The screenshot below shows charge detail at Omise dashboard. This charge was created from the above checkout.

Test case 2: Failed checkout

• From the above success checkout, refresh the web browser page.

The screenshot below shows the result page display the error payment.

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

The function to handle the create Omise charge error will be developed for the next pull request.

The screenshot below shows the passed unit tests at Travis CI.

[guzzilar]

FYI: Im gonna close this PR since this one already merged to #19 and we're going to review this changes in that PR.

Thanks for the changes 👍

Note, the reason we moved is, because PR #14 and #17 were made to introduce Omise Charge service to the plugin but this PR did refactoring code based on those changes (#14, #17).

To make the review process more easy to follow with and more clear the big picture of those changes (including this refactoring changes). We decided to merge all of them into 1 branch, which is #19.