omise / omise-prestashop

Omise PrestaShop Plugin
https://docs.opn.ooo/prestashop-plugin
MIT License
4 stars 7 forks source link

Remove unnecessary HTML <p> tag #34

Closed nimid closed 7 years ago

nimid commented 7 years ago

1. Objective

Remove an invalid <p> tag in the card payment page. This <p> tag contains <div> tag which is invalid. It will causes an error when the debug mode has been activated.

This <p> tag does not affect the display. It does not have any CSS rules declared on it.

Related information:

2. Description of change

Remove an <p> tag and correct the indentation.

3. Quality assurance

Environments:

Details:

Before change

The screenshot below shows an error at checkout page when debug mode has been activated.

omise-prestashop-error-in-debug-mode-at-card-payment-page-invalid-p-tag

After change

The screenshot below shows the checkout page. The page can be rendered and displayed normally.

omise-prestashop-card-payment-form-on-prestashop-1 7

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

To activate debug mode in PrestaShop, it can be done by go to PrestaShop back office. From the left menu, go to CONFIGURE > Advanced Parameters > Performance > DEBUG MODE.

The screenshot below shows the debug mode configuration.

prestashop-1 7-advanced-parameters-performance-debug-mode

After debug mode has been activated, PrestaShop will shows that the system is in debug mode from the left top indicator.

The screenshot below shows the indicator that PrestaShop is in debug bug mode.

prestashop-1 7-debug-mode-has-been-activated

Reference:

The P element represents a paragraph. It cannot contain block-level elements (including P itself).