omise / omise-prestashop

Omise PrestaShop Plugin
https://docs.opn.ooo/prestashop-plugin
MIT License
4 stars 7 forks source link

Prevent popup of error notification at setting page in debug mode #36

Closed nimid closed 7 years ago

nimid commented 7 years ago

1. Objective

Prevent the popup of error notification at setting page in debug mode.

Related information:

2. Description of change

Add a condition in setting page to check whether the confirmation message has been assigned from the server side to client side.

3. Quality assurance

Environments:

Details:

Steps to reproduce:

dashboard_ _omise_prestashop module_selection_ _omise_prestashop manage_installed_modules_ _omise_prestashop

Before change:

The screenshot below shows the popup of error message at setting page when the merchant open setting page in debug mode.

undefined-variable-confirmation

After change:

It has no popup of error message when open the setting page in debug mode.

omise-prestashop-setting-page-in-debug-mode

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

This problem is not occurred in normal mode.