Create Omise internet banking charge

[nimid]

1. Objective

Create Omise internet banking charge.

Related information:

• Related issue: #28
• Related ticket: -

2. Description of change

• Develop client-side script, JavaScript, to submit a selected bank in internet banking form to server side.

• Change a PrestaShop deprecated function, Order.getOrderByCartId(), to a function Order. getIdByCartId().

• Change style of HTML ID of elements in internet banking payment. Change from camel case to be separated with hyphen.

3. Quality assurance

Environments:

• Platform: PrestaShop 1.7.2.3
• Omise plugin: Omise PrestaShop 1.2
• PHP: 5.6.31

Details:

There are 7 test cases below.

1. Successfully create Omise internet banking charge with Siam Commercial Bank (SCB)
2. Successfully create Omise internet banking charge with Krungthai Bank (KTB)
3. Successfully create Omise internet banking charge with Krungsri Bank (BAY)
4. Successfully create Omise internet banking charge with Bangkok Bank (BBL)
5. No any bank has been selected, display custom client-side script (jQuery Fancybox) warning message.
6. No any bank has been selected, display native client-side script warning message, if the jQuery Fancybox can not be loaded.
7. Failed create Omise internet banking payment charge.

Steps before test.

• Install and enable Omise payment module.
• At PrestaShop back office, Omise configuration page, enable internet banking payment.
• Go to PrestaShop front office, make sure current currency is applicable such as THB.
• Proceed checkout.
• At the payment step, select Internet Banking.

1. The screenshot below shows Omise dashboard, charge detail. This charge is internet banking charge with SCB.

2. The screenshot below shows Omise dashboard, charge detail. This charge is internet banking charge with KTB.

3. The screenshot below shows Omise dashboard, charge detail. This charge is internet banking charge with BAY.

4. The screenshot below shows Omise dashboard, charge detail. This charge is internet banking charge with BBL.

5. The screenshot below shows PrestaShop 1.7 front office, Omise internet banking payment form. It shows custom client-side script (jQuery Fancybox) warning message, when internet banking payment form has no any selected bank.

6. The screenshot below shows PrestaShop 1.7 front office, Omise internet banking payment form. It shows native client-side script warning message, when internet banking payment form has no any selected bank and the jQuery Fancybox can not be loaded.

7. The screenshot below shows PrestaShop 1.7 front office, failed Omise internet banking payment.

The screenshot below shows PrestaShop 1.7 back office, failed Omise internet banking payment. The order has been automatically canceled.

The screenshot below shows Omise dashboard failed internet banking charge.

4. Impact of the change

-

5. Priority of change

Normal

6. Additional notes

Reference to the PrestaShop 1.7 deprecated function, Order.getOrderByCartId().