Save payment method name correctly as selected by payer.
Currently, Omise PrestaShop has more than one payment method, card payment and internet banking payment. The payment method name that saved to the order should reflected the actual payment method that was chosen by the payer.
Related information:
Related issue: -
Related ticket: -
2. Description of change
Modify a function for save the order, PaymentOrder.save(). Make it requires one more parameter, payment method name.
Modify all functions that saving the order. Make it send the required parameters.
Unused and remove a function, PaymentOrder.saveAsProcessing(). To make the module has one function for save the order which is PaymentOrder.save().
Change the field used to check the condition of the module of saved order, when return from Omise API.
3. Quality assurance
Environments:
Platform: PrestaShop 1.7.2.4
Omise plugin: Omise PrestaShop 1.3
PHP: 5.6.31
Details:
Before change
The payment method name that saved to the order has been fixed by using name, Omise (Omise::MODULE_DISPLAY_NAME).
The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method of this order is fixed, Omise.
After change
The payment method that saved to the order is the actual payment method that selected by payer.
The screenshot below shows PrestaShop front office, completed card payment page. In the red box, the payment method name of card payment is the setting of title.
The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method name of card payment is the setting of title.
The screenshot below shows PrestaShop front office, completed internet banking payment page. In the red box, the payment method name is Internet Banking.
The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method name of internet banking payment is Internet Banking.
4. Impact of the change
-
5. Priority of change
Normal
6. Additional notes
For the payment method name saved to the order, card payment is the setting of title. Internet banking payment is fixed the name Internet Banking.
1. Objective
Save payment method name correctly as selected by payer.
Currently, Omise PrestaShop has more than one payment method, card payment and internet banking payment. The payment method name that saved to the order should reflected the actual payment method that was chosen by the payer.
Related information:
2. Description of change
Modify a function for save the order,
PaymentOrder.save(). Make it requires one more parameter, payment method name.Modify all functions that saving the order. Make it send the required parameters.
Unused and remove a function,
PaymentOrder.saveAsProcessing(). To make the module has one function for save the order which isPaymentOrder.save().Change the field used to check the condition of the module of saved order, when return from Omise API.
3. Quality assurance
Environments:
Details:
Before change
The payment method name that saved to the order has been fixed by using name, Omise (
Omise::MODULE_DISPLAY_NAME).The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method of this order is fixed, Omise.
After change
The payment method that saved to the order is the actual payment method that selected by payer.
The screenshot below shows PrestaShop front office, completed card payment page. In the red box, the payment method name of card payment is the setting of title.
The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method name of card payment is the setting of title.
The screenshot below shows PrestaShop front office, completed internet banking payment page. In the red box, the payment method name is Internet Banking.
The screenshot below shows PrestaShop back office, order detail page. In the red box, the payment method name of internet banking payment is Internet Banking.
4. Impact of the change
-5. Priority of change
Normal
6. Additional notes
For the payment method name saved to the order, card payment is the setting of title. Internet banking payment is fixed the name Internet Banking.