Bugfixes - Githubissues

omise / omise-prestashop

Omise PrestaShop Plugin

https://docs.opn.ooo/prestashop-plugin

MIT License

4 stars 7 forks source link

Bugfixes #66

Closed jonrandy closed 6 years ago

jonrandy commented 6 years ago

1. Objective

Fix the 500 error occurring when payments fail on Prestashop 1.6
Fix the English on the 'payment error' page
Fix the longstanding issue with checkboxes sometimes not appearing to specifiy what currencies to allow for the Omise payment plugin
Fix the error thrown by the Webhooks controller (issue #67)

2. Description of change

Adds a version specific template for the 'Payment error' page
Changes the path for the webhooks template as it differs between Prestashop versions
Changes the English message displayed on these templates
Changes the configuration/setup of the plugin so that need_instance is turned on - the instance is always then available as needed on the payment plugin prefs admin page (fix gleaned from extensive searching on Google and forums)

3. Quality assurance

Re-checked all affected areas on both versions of Prestashop (payment error page and payment prefs admin page)

4. Impact of the change

All bugs listed in Objectives are now fixed

5. Priority of change

High. Merchants waiting on fixes

6. Additional notes

Do you personally accept that 1 / 0 = ∞?

guzzilar commented 6 years ago

@jonrandy can you also refer to the issue this PR is fixing in the pull request description? (I guess this one #67 ?)