omise / omise-prestashop

Omise PrestaShop Plugin
https://docs.opn.ooo/prestashop-plugin
MIT License
4 stars 7 forks source link

Fix small HTTPS issue and prepare 1.7.9 release #90

Closed jonrandy closed 4 years ago

jonrandy commented 4 years ago

1. Objective

Related information: Related issue(s): #89

This fixes a small issue (possibly introduced during refactoring) that was causing issues in environments where HTTPS was being enforced everywhere (no payment methods would work at checkout, customers were just redirected back to the checkout page).

The PR also makes the small preparations necessary for v1.7.9 release with this fix.

2. Description of change

The function responsible for generating links was changed to default to secure.

3. Quality assurance

I worked with the merchant who reported the issue to get him to test it in the environment where the issue was occurring. He confirmed it now worked fine.

4. Impact of the change

Plugin will now work successfully in strict HTTPS only environments

5. Priority of change

Normal

jonrandy commented 4 years ago

Done