Introducing Konbini payment method

guzzilar commented 4 years ago

1. Objective

Omise has been providing a payment service (credit card) for Japan for a couple years. And now, we have also delivered a brand-new payment method, "Konbini" recently that would enable more opportunities for merchants and buyers that are living in Japan to have more choice of payments and to make the payment experience even better.

Now it's time to bring this new payment feature to Omise-WooCommerce plugin

Related information: Related issue(s): T17761 (internal ticket)

2. Description of change

Displaying "Konbini" payment method on both Admin and checkout page.
Merchant will be able to enable "Konbini" payment start accepting payment through Konbini.
Buyers will be able to select "Konbini" as a payment method when checking out an order.

3. Quality assurance

🔧 Environments:

WooCommerce: v4.3.3
WordPress: v5.4.2
PHP version: 7.3.3

✏️ Details:

4. Impact of the change

none

5. Priority of change

Normal

6. Additional Notes

As this payment method is aiming for Japanese market, this plugin should be translated in Japanese language before release.

jacstn commented 4 years ago

please consider payment link to be opened in a separated window

guzzilar commented 4 years ago

please consider payment link to be opened in a separated window

@jacstn Hi, is there any reason why we want to open a link in a separated window?

jacstn commented 4 years ago

@guzzilar Separated browser tab precisely, The reason is that you never are redirected back to the shop, once you click this button.

If the user entered this shop from some facebook ads as an example, he will have to be searching all browser history, or google it, if he does not remember the shop name it might be not comfortable from the UX perspective.

guzzilar commented 4 years ago

@guzzilar Separated browser tab precisely, The reason is that you never are redirected back to the shop, once you click this button.

If the user entered this shop from some facebook ads as an example, he will have to be searching all browser history, or google it, if he does not remember the shop name it might be not comfortable from the UX perspective.

Interesting case 👍 Would it be any reason that the user have to search all browser history or google it to get back to the shop? Also, isn't normally after the purchase, you will be going out to a convenience store and open a link from their email?

But still interesting, I'll ask Japan team to help overlook & adjusting the work-flow more. Thanks for the input 👍

jacstn commented 4 years ago

Not sure if it is japan team or UX team that would answer this question,

so scenario:

you browse facebook looking at your photos of your friends
you see an Ad of store selling shoes, you have never seen that store before
you are redirected directly to the product -> from facebook to store.
you add it to cart and you chose a payment method konbini
you are redirected to the payment and have no possibility to go back. you are compleately detached from that store in the current solution.
If you want to continue shopping or check anything else there, you need to remember the shop name and google it, or browse your history, or check emails. Opening in a new tab might solve those issues.

Why you are so anti opening in a new tab @guzzilar ?

guzzilar commented 4 years ago

@jacstn I'm just simply asking questions to understand the idea behind before making a change why you assumed that I am anti? : )))

guzzilar commented 4 years ago

@jacstn and the scenario that you gave is really well-described. Now I understand your point more. Thanks, let's try ;)

jonrandy commented 4 years ago

If opening in a new tab - be sure to indicate in some way that this will occur

jonrandy commented 4 years ago

Oops! Obviously use a smaller image than that! 😛

jonrandy commented 4 years ago

Not sure if it is japan team or UX team that would answer this question,

so scenario:

1. you browse facebook looking at your photos of your friends

2. you see an Ad of store selling shoes, you have never seen that store before

3. you are redirected directly to the product -> from facebook to store.

4. you add it to cart and you chose a payment method konbini

5. you are redirected to the payment and have no possibility to go back. you are compleately detached from that store in the current solution.

6. If you want to continue shopping or check anything else there, you need to remember the shop name and google it, or browse your history, or check emails.
   Opening in a new tab might solve those issues.

Why you are so anti opening in a new tab @guzzilar ?

Wouldn't the back button get them back? Or am I missing something? I've got nothing against new tab though

jonrandy commented 4 years ago

Some other thoughts on new tabs:

https://uxdesign.cc/linking-to-a-new-tab-vs-same-tab-f88b495d2187 https://medium.com/the-metric/links-should-open-in-the-same-window-447da3ae59ba https://grrr.tech/posts/opening-links-in-new-tabs/

I haven't read all these other than a quick scan. Just thought we should consult the interwebs too

jacstn commented 4 years ago

I think request data should be validated still in the store before being sent to omise backend. Might be done in other PR.

omise / omise-woocommerce