search

omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

(proposal) Code cleaning for payment method classes. #153

Closed guzzilar closed 4 years ago

guzzilar commented 4 years ago

1. Objective

This code is a proposal of removing an unnecessary code for registering and listing up Omise payment methods.

Related information: Related issue(s): T19568 (internal ticket)

2. Description of change

Refactoring part of code that was used for registering Omise payment methods to WooCommerce.

As well as, removing the redundant code.

3. Quality assurance

  1. Making sure that all the payment methods can be listed out at the WooCommerce payment setting page.

  2. Making sure that all the payment methods can be used as normal at WooCommerce checkout page.

4. Impact of the change

None

5. Priority of change

Normal

6. Additional Notes

guzzilar commented 4 years ago

@jonrandy I removed the whole 'payment methods' class. Can you help check it again? Thanks :D

jonrandy commented 4 years ago

I think because you 'force pushed' I'm having trouble working out what you've actually removed as those commits are gone. I always find it best never to force push anything - unless it's a last resort to fix some Git weirdness

guzzilar commented 4 years ago

@jonrandy about force push, you're right. I forgot. The change I've made is to remove the includes/class-omise-payment-methods.php (the one that you mentioned about singleton) and having a list of payment method classname at omise-woocommerce.php file instead (here: https://github.com/omise/omise-woocommerce/pull/153/files#diff-da400947a51dd0d488fcdb5ac3a4edd4R99).