Updating translation for Japanese language in konbini payment. - Githubissues

omise / omise-woocommerce

Omise WooCommerce Plugin

https://docs.opn.ooo/woocommerce-plugin

MIT License

47 stars 27 forks source link

Updating translation for Japanese language in konbini payment. #204

Closed mayurkathale closed 3 years ago

mayurkathale commented 3 years ago

1. Objective

This PR is to update the Japanese translation file which updates text on order complete page.

Few code style formatting has been done in translation file.

Following text which is highlighted change to Japanese language. image-20201026-033249

Changed text:

Screen Shot 2020-12-18 at 10 24 37

Related information: Internal issue(s): https://omise.atlassian.net/browse/FES-247

2. Description of change

Updated PO and POT file for translations
Modified rendering text in template file:includes/gateway/class-omise-payment-konbini.php

3. Quality assurance

🔧 Environments:

WooCommerce: v4.3.0
WordPress: v5.4.2
PHP version: 7.3.3
Omise plugin version: Omise-WooCommerce 4.3 (optional, in case of submitting a new issue)

✏️ Details:

Switch to japanese language in Wordpress. from Backend > Setting > General > select "Japanese".
Download Japanese translations in backend.
Checkout with Konbini payment and complete the order placement
Check Order success page for updated translation.

4. Impact of the change

None

5. Priority of change

Normal

6. Additional Notes

NA