Closed kan98 closed 2 years ago
som-m
commented
2 years ago Should we also consider this scenario where a charge is captured via other means (dashboard, api, etc.), then manual sync is performed on WooCommerce to fetch the latest status of the charge. is_awaiting_capture is not updated. The capture button is still there even though the charge has already been captured.
kan98
commented
2 years ago Should we also consider this scenario where a charge is captured via other means (dashboard, api, etc.), then manual sync is performed on WooCommerce to fetch the latest status of the charge.
is_awaiting_captureis not updated. The capture button is still there even though the charge has already been captured.
yes great catch @som-m! It's fixed in this commit https://github.com/omise/omise-woocommerce/pull/248/commits/0295e8450c373951a81f6559f333b58033f1fc3f
1. Objective
Explain in non-technical terms WHY this PR is required. E.g.: What feature it adds, what problem it solves...
This section will be used in the release notes.
Add Rabbit LINE Pay payment method to the plugin for Thai merchants.
Related information: Related issue(s): #< GitHub ticket number > (optional)
2. Description of change
A general description of WHAT changed in the codebase, but short of an English version of the diff. Assume that people reading this will also be looking at the output of
git diffand guide them to the highlights.Additionally add the reasoning for change details if they're complex or abstract.
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
Should do full flow manual testing
🔧 Environments:
Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.
i.e.
✏️ Details:
Explain how to manually test this feature. For example if changes were made in the UI or in the API, explain where and if any specific access is needed.
Test charge capture flow for manual capturing charges Test RLP for both auto and manual capture flow
4. Impact of the change
List the steps that must be taken for this PR to work. E.g.: rake yak:shave, Add "yak_key" to environment variables, ...
Be sure to include all systems that needs to be changed or which system is affected by the change (Ex: Requires Elastic search to be installed and configured in secrets.yml).
Note: Please provide a screenshot if your changed impact to UI.
5. Priority of change
Normal, High or Immediate.
Normal
6. Additional Notes
Any further information that you would like to add.