[APM2-579] Add checkout filter currency for mobile banking

[new4762]

1. Objective

Fix displaying payment options for mobile banking to display only support checkout currency

Task: https://omise.atlassian.net/browse/APM2-579

2. Description of change

add backend filter by checkout currency from woocommerce api

3. Quality assurance

Test this update locally and ensure pyament methods shows up correctly

🔧 Environments:

Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.

• WooCommerce: v6.2.2
• WordPress: v5.9.1
• PHP version: 7.3.33
• Omise plugin version: Omise-WooCommerce 4.16

✏️ Details:

Enable Mobile banking through Omise setting and try to checkout selecting mobile banking as payment method, a form should show only support options. (try switching currency in woocommerce setting in Currency options

4. Impact of the change

Before

After

5. Priority of change

Normal

6. Additional Notes

Any further information that you would like to add.

[kan98]

not sure if it's worth adding a bit of styling on the mobile bank list? the logo placement seems a little off to me

[new4762]

not sure if it's worth adding a bit of styling on the mobile bank list? the logo placement seems a little off to me

What about this one 🤔

[kan98]

not sure if it's worth adding a bit of styling on the mobile bank list? the logo placement seems a little off to me

What about this one 🤔

@new4762 looks good!

[FhanOmise]

trying to follow this one any suggestions 🙏

  /**
   * Retrieves details of installment payment backends from capabilities.
   *
   * @return string
   */
  public function getInstallmentBackends( $currency = '', $amount = null ) {

      $params   = array();
      $params[] = $this->capabilities->backendFilter['type']('installment');

      if ( $currency ) {
          $params[] = $this->capabilities->backendFilter['currency']( $currency );
      }
      if ( ! is_null( $amount ) ) {
          $params[] = $this->capabilities->backendFilter['chargeAmount']( $amount );
      }

      return $this->capabilities->getBackends( $params );
  }

@new4762 @kan98 Maybe because they want $params and $params[] to have aligned =. But getBackends() have only 1 assignment. I think we can remove the exceeded space, wdyt? And maybe consider add space after $currency = '' for below too.

https://github.com/omise/omise-woocommerce/blob/ea946fed4f6ee1e4faa56100a407d46057ba7f92/includes/class-omise-capabilities.php#L55

[kan98]

trying to follow this one any suggestions 🙏

    /**
     * Retrieves details of installment payment backends from capabilities.
     *
     * @return string
     */
    public function getInstallmentBackends( $currency = '', $amount = null ) {

        $params   = array();
        $params[] = $this->capabilities->backendFilter['type']('installment');

        if ( $currency ) {
            $params[] = $this->capabilities->backendFilter['currency']( $currency );
        }
        if ( ! is_null( $amount ) ) {
            $params[] = $this->capabilities->backendFilter['chargeAmount']( $amount );
        }

        return $this->capabilities->getBackends( $params );
    }

@new4762 @kan98 Maybe because they want $params and $params[] to have aligned =. But getBackends() have only 1 assignment. I think we can remove the exceeded space, wdyt? And maybe consider add space after $currency = '' for below too.

https://github.com/omise/omise-woocommerce/blob/ea946fed4f6ee1e4faa56100a407d46057ba7f92/includes/class-omise-capabilities.php#L55

yea it only had one assignment which was what confused me aha. I think we should go with your suggestions

[new4762]

trying to follow this one any suggestions 🙏

  /**
   * Retrieves details of installment payment backends from capabilities.
   *
   * @return string
   */
  public function getInstallmentBackends( $currency = '', $amount = null ) {

      $params   = array();
      $params[] = $this->capabilities->backendFilter['type']('installment');

      if ( $currency ) {
          $params[] = $this->capabilities->backendFilter['currency']( $currency );
      }
      if ( ! is_null( $amount ) ) {
          $params[] = $this->capabilities->backendFilter['chargeAmount']( $amount );
      }

      return $this->capabilities->getBackends( $params );
  }

@new4762 @kan98 Maybe because they want $params and $params[] to have aligned =. But getBackends() have only 1 assignment. I think we can remove the exceeded space, wdyt? And maybe consider add space after $currency = '' for below too. https://github.com/omise/omise-woocommerce/blob/ea946fed4f6ee1e4faa56100a407d46057ba7f92/includes/class-omise-capabilities.php#L55

yea it only had one assignment which was what confused me aha. I think we should go with your suggestions

@FhanOmise @kan98 Fixed 🙏 -> https://github.com/omise/omise-woocommerce/pull/249/commits/6d3c42c6e0b7d344c1251eeafa294dbf28500196

[tanawin-opn]

test with multiple currency worked correctly krub.

but please check the plugin version number, because it's back and forth between 4.16 and 4.17. I think it might be a problem when release krub.

[new4762]

test with multiple currency worked correctly krub.

but please check the plugin version number, because it's back and forth between 4.16 and 4.17. I think it might be a problem when release krub.

Thanks you very much kub 🙇