omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

[APM2-695] FPX logo, banklist and terms & condition #275

Closed new4762 closed 2 years ago

new4762 commented 2 years ago

1. Objective

FPX Logo and terms and condition was missing , and bank options is not well ux for customer so this PR will update FPX Logo and terms and condition and changes radio option to be selection.

This section will be used in the release notes.

Related information: Related issue(s): https://omise.atlassian.net/browse/APM2-695

2. Description of change

3. Quality assurance

Specify where and how you tested this and what further testing it might need.

🔧 Environments:

WooCommerce: v6.2.2 WordPress: v5.9.1 PHP version: 7.3.33 Omise plugin version: Omise-WooCommerce 4.20

✏️ Details:

Using Malaysia key to create FPX charges and make sure charges is create correctly

4. Impact of the change

image image image image image image

5. Priority of change

Normal

6. Additional Notes

Any further information that you would like to add.

new4762 commented 2 years ago

Can we please also make all the spacing consistent ka? Otherwise 👍

image

@som-m do you mean spacing top down between components right krub

tanawin-opn commented 2 years ago

working correctly krub.

image
new4762 commented 2 years ago

working correctly krub. image

@tanawin-opn Thanks for the review krub 🙏

new4762 commented 2 years ago

This PR will release after 2nd June (should be 6th June)