omise / omise-woocommerce

Omise WooCommerce Plugin
https://docs.opn.ooo/woocommerce-plugin
MIT License
47 stars 27 forks source link

[ENGA3-290]: Issue of displaying an error as an option of Online bank… #296

Closed aashishgurung closed 2 years ago

aashishgurung commented 2 years ago

1. Objective

Fix the issue of displaying an error as an option of Online bank ing (FPX) when one of the bank is set as inactive

Jira: #290

2. Description of change

In templates/payment/form-fpx.php line 11, disabled was not wrapped by quote so PHP interpreted it as a constant. I changed the disabled into "disabled" to fix the issue.

3. Quality assurance

Change to Malaysia PSP and see the drop down of the online banking (FPX) by going to the checkout page.

Before

Screen Shot 2565-08-22 at 10 55 35

After

Screen Shot 2565-08-22 at 10 54 01

🔧 Environments:

Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.

i.e.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication